Add vLLM transformers backend to online methods #3773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@qgallouedec @kashif this works, apparently my compiled dev version for vLLM was causing all the issue, updating v1 solved it! |
kashif
reviewed
Jul 30, 2025
| @@ -393,6 +393,14 @@ class GRPOConfig(TrainingArguments): | |||
| "contention with training." | |||
| }, | |||
| ) | |||
| vllm_model_impl: str = field( | |||
There was a problem hiding this comment.
can you also add these doc in the docstrings further up in the file?
| @@ -292,6 +292,14 @@ class ScriptArguments: | |||
| "'trace'." | |||
| }, | |||
| ) | |||
| vllm_model_impl: str = field( | |||
There was a problem hiding this comment.
It's missing in the docstring above
| @@ -164,6 +164,14 @@ class may differ from those in [`~transformers.TrainingArguments`]. | |||
| "(`pip install vllm`)." | |||
| }, | |||
| ) | |||
| vllm_model_impl: str = field( | |||
docs/source/vllm_integration.md
Outdated
|
|
||
| ## vLLM with Transformers Backend | ||
|
|
||
| vLLM now supports transformers backend for model implementations. Simply passing in `transformers` in `vllm_model_impl` in configurations or through argument parser will set use transformers backend. See an example below. |
There was a problem hiding this comment.
Does it support VLMs? Limitations?
Additionally, maybe linking the blog: https://blog.vllm.ai/2025/04/11/transformers-backend.html
(in case these ideas can be added in 1-2 sentences)
kashif
approved these changes
Jul 30, 2025
sergiopaniego
approved these changes
Jul 30, 2025
|
@kashif can you merge 🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add vLLM transformers backend to online methods GRPO and online DPO.
This has two limitations:
VLLM_USE_PRECOMPILED=1 uv pip install -e .I will check the issues, you can test with
while serving with