↔️ Fix CB in GRPO #3722
Merged
↔️ Fix CB in GRPO #3722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qgallouedec
commented
Jul 11, 2025
| prompt_ids = [torch.tensor(ids, device=device) for ids in prompt_inputs.input_ids] | ||
| prompt_ids = pad(prompt_ids, padding_value=self.processing_class.pad_token_id) | ||
| prompt_ids = pad(prompt_ids, padding_value=self.processing_class.pad_token_id, padding_side="left") |
There was a problem hiding this comment.
Padding side must be "left" for prompts, otherwise you'd get (incorrect):
[[P01, P01, P03, PAD, PAD, C01, C02, C03, C04],
[P11, P11, P13, P14, P15, C11, C12, PAD, PAD]]
instead of (correct)
[[PAD, PAD, P01, P01, P03, C01, C02, C03, C04],
[P11, P11, P13, P14, P15, C11, C12, PAD, PAD]]
There was a problem hiding this comment.
then how we got reasonable output till now? 🧐
There was a problem hiding this comment.
the error is only when using CB, introduced in #3471
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
qgallouedec
commented
Jul 11, 2025
Comment on lines
+1235
to
+1242
| with ( | ||
| profiling_context(self, "transformers.generate"), | ||
| unwrap_model_for_generation( | ||
| self.model_wrapped, self.accelerator, gather_deepspeed3_params=self.args.ds3_gather_for_generation | ||
| ) as unwrapped_model, | ||
| torch.no_grad(), | ||
| FSDP.summon_full_params(self.model_wrapped, recurse=False) if self.is_fsdp_enabled else nullcontext(), | ||
| ): |
There was a problem hiding this comment.
simplification, using
with c1, c2:instead of
with c1:
with c2:|
good catch! lets also pin the transformer to the latest patch for the generation length fix? |
|
can you kindly test with |
kashif
approved these changes
Jul 11, 2025
done in 17157c4 |
marcandrelarochelle
pushed a commit
to marcandrelarochelle/trl
that referenced
this pull request
Jul 29, 2025
Co-authored-by: Shirin Yamani <75791599+shirinyamani@users.noreply.github.com>
LuisVasquezBSC
pushed a commit
to langtech-bsc/trl
that referenced
this pull request
Aug 28, 2025
Co-authored-by: Shirin Yamani <75791599+shirinyamani@users.noreply.github.com>
LuisVasquezBSC
pushed a commit
to langtech-bsc/trl
that referenced
this pull request
Aug 28, 2025
Co-authored-by: Shirin Yamani <75791599+shirinyamani@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Padding side was wrong, this PR is a fix
A few cleanup, late review for #3471
cc @ArthurZucker for viz