fix: support dict access in SFT Trainer #3677
Merged
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
5 tasks
kashif
approved these changes
Jul 2, 2025
kashif
reviewed
Jul 2, 2025
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Co-authored-by: Kashif Rasul <kashif.rasul@gmail.com>
|
thanks @jannisborn one more formatting left... perhaps easiest if you run |
|
Thanks @kashif for catching this, the format-on-save in my IDE reorganized the entire file, so I had to disable it. Should be fixed now! |
|
@jannisborn yes the formatting is tricky... still failing |
|
@jannisborn I believe the CI is failing due to un-releated reasons... I will double check locally |
|
Indeed @kashif -- it seemed like a network issue, maybe just rerunning the CI will fix it. I rebased to main now |
marcandrelarochelle
pushed a commit
to marcandrelarochelle/trl
that referenced
this pull request
Jul 29, 2025
Co-authored-by: Kashif Rasul <kashif.rasul@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #3641 (issue)
Before submitting
Pull Request section?
to it if that's the case. Unnecessary breaking change in
SFTTrainer._prepare_datasetfrom 0.19.0 compared to 0.18.2 #3641Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.