-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add "🐯 Liger GRPO meets TRL" #3525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a new blog link card for the “🐯 Liger GRPO meets TRL” post to the homepage index.
- Introduces a new
<a>
block in docs/source/index.md pointing to the Liger GRPO blog post. - Displays thumbnail, publication date, and title with emoji.
@@ -28,6 +28,11 @@ The documentation is organized into the following sections: | |||
|
|||
<div class="mt-10"> | |||
<div class="w-full flex flex-col space-y-4 md:space-y-0 md:grid md:grid-cols-2 md:gap-y-4 md:gap-x-5"> | |||
<a class="!no-underline border dark:border-gray-700 p-5 rounded-lg shadow hover:shadow-lg" href="https://huggingface.co/blog/liger-grpo"> | |||
<img src="https://raw.githubusercontent.com/huggingface/blog/main/assets/liger-grpo/thumbnail.png" alt="thumbnail" class="mt-0"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The alt text is generic. For better accessibility, use a more descriptive alt attribute, e.g., alt="Liger GRPO meets TRL thumbnail"
.
Copilot uses AI. Check for mistakes.
<a class="!no-underline border dark:border-gray-700 p-5 rounded-lg shadow hover:shadow-lg" href="https://huggingface.co/blog/liger-grpo"> | ||
<img src="https://raw.githubusercontent.com/huggingface/blog/main/assets/liger-grpo/thumbnail.png" alt="thumbnail" class="mt-0"> | ||
<p class="text-gray-500 text-sm">Published on May 25, 2025</p> | ||
<p class="text-gray-700">🐯 Liger GRPO meets TRL</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider wrapping the emoji in a <span role="img" aria-label="tiger">🐯</span>
to ensure screen readers announce it correctly.
<p class="text-gray-700">🐯 Liger GRPO meets TRL</p> | |
<p class="text-gray-700"><span role="img" aria-label="tiger">🐯</span> Liger GRPO meets TRL</p> |
Copilot uses AI. Check for mistakes.
cc @shivam15s |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Uh oh!
There was an error while loading. Please reload this page.