Skip to content

🧭 Patch release guide #3512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025
Merged

🧭 Patch release guide #3512

merged 1 commit into from
May 30, 2025

Conversation

qgallouedec
Copy link
Member

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CONTRIBUTING.md guide to include new instructions for making patch releases and clarifies the major/minor release process. The key changes include:

  • Introducing a "Major/Minor Release" section with updated versioning instructions.
  • Updating commit instructions to include additional files such as trl/init.py and a workflow file.
  • Adding a comprehensive "Making a patch release" section with step-by-step commands for cherry-picking commits, updating versions, and publishing releases.

@@ -646,3 +647,121 @@ twine upload dist/*
5. Once the pull request is approved, merge it into `main`.

6. The codebase is now ready for the next development cycle, inform the team in the #trl-internal channel.


## Making a patch release
Copy link
Preview

Copilot AI May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding a brief introductory note for the patch release section that explains its purpose and context to help users understand when to follow these steps.

Copilot uses AI. Check for mistakes.


- `trl/__init__.py`
```diff
- __version__ = "{major}.{minor}.{patch-1}"
Copy link
Preview

Copilot AI May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Clarify the use of the placeholders (e.g., {patch-1} to {patch}) in the versioning instructions. This could prevent any potential confusion about how version numbers should be incremented during a patch release.

Copilot uses AI. Check for mistakes.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@qgallouedec qgallouedec changed the title Patch release guide 🧭 Patch release guide May 30, 2025
@qgallouedec qgallouedec merged commit 0844936 into main May 30, 2025
2 checks passed
@qgallouedec qgallouedec deleted the patch-release-guide branch May 30, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants