Skip to content

📎 Fix clip ratio logging #3506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

📎 Fix clip ratio logging #3506

merged 1 commit into from
May 28, 2025

Conversation

qgallouedec
Copy link
Member

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@qgallouedec qgallouedec requested review from lewtun, shirinyamani, kashif and edbeeching and removed request for lewtun May 28, 2025 14:50
lewtun
lewtun approved these changes May 28, 2025
View reviewed changes
Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@qgallouedec qgallouedec changed the title Fix clip ratio logging 📎 Fix clip ratio logging May 28, 2025
@qgallouedec qgallouedec merged commit c13de6f into main May 28, 2025
10 of 11 checks passed
@qgallouedec qgallouedec deleted the qgallouedec-patch-1 branch May 28, 2025 15:46
qgallouedec added a commit that referenced this pull request May 29, 2025
@qgallouedec
📎 Fix clip ratio logging (#3506)
1bae58c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewtun lewtun lewtun approved these changes

@shirinyamani shirinyamani Awaiting requested review from shirinyamani

@kashif kashif Awaiting requested review from kashif

@edbeeching edbeeching Awaiting requested review from edbeeching

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qgallouedec @lewtun