enable activation offloading on XPU #3444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matrix Yao <matrix.yao@intel.com>
yao-matrix
commented
May 14, 2025
| ) | ||
| # NOTE: xpu doesn't have `default_stream` API, use `current_stream` instead | ||
| self.s0 = ( | ||
| torch.xpu.current_stream() if self.accelerator_type == "xpu" else torch.cuda.default_stream() |
There was a problem hiding this comment.
@gujinghui, pls help review this logic. Since xpu doesn't have default_stream, so i am using current_stream to WA.
There was a problem hiding this comment.
LGTM. As long as the workload has no specific assumption on cuda default stream, the current stream is good enough to replace it for functionality.
|
@kashif , pls help review, thx. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
kashif
reviewed
May 15, 2025
kashif
reviewed
May 16, 2025
|
seems the ci failures are not brought by my PR @kashif |
kashif
approved these changes
May 19, 2025
shirinyamani
pushed a commit
that referenced
this pull request
May 19, 2025
Signed-off-by: Matrix Yao <matrix.yao@intel.com> Co-authored-by: Kashif Rasul <kashif.rasul@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.