Skip to content

Conversation

kashif
Copy link
Collaborator

@kashif kashif commented Feb 13, 2025

What does this PR do?

fixes #2671

@kashif kashif requested a review from qgallouedec February 13, 2025 09:59
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
@qgallouedec qgallouedec merged commit 9b3c5bf into main Feb 18, 2025
12 of 14 checks passed
@qgallouedec qgallouedec deleted the issue-2671 branch February 18, 2025 17:09
@qgallouedec qgallouedec changed the title [GRPO] add gradient_checkpointing 📍 [GRPO] add gradient_checkpointing Feb 18, 2025
yxliu-TAMU pushed a commit to mincheolseong/ECEN743-GRPO-Project-Proposal that referenced this pull request Apr 20, 2025
* add gradient_checkpointing

* added a helper

* Update trl/trainer/grpo_trainer.py

Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>

* Update trl/trainer/grpo_trainer.py

Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>

* minor refactor for better readability

* use acceelrate util

* enable_input_require_grads is in base class

---------

Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
Co-authored-by: Quentin Gallouédec <quentin.gallouedec@huggingface.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"None of the inputs have requires_grad=True" with online DPO and GRPO
3 participants