👯 Standardize model_args
#2442
Merged
👯 Standardize model_args
#2442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
qgallouedec
commented
Dec 5, 2024
| @@ -898,8 +900,9 @@ def get_kbit_device_map() -> Optional[dict[str, int]]: | |||
| return None | |||
|
|
|||
|
|
|||
| def get_peft_config(model_config: ModelConfig) -> "Optional[PeftConfig]": | |||
| if model_config.use_peft is False: | |||
| @deprecate_kwarg("model_config", "0.14.0", "model_args", warn_if_greater_or_equal_version=True) | |||
There was a problem hiding this comment.
I'm pretty sure no one uses this function with this keyword argument syntax; (use argument form instead). But still, let's deprecate first.
lewtun
approved these changes
Dec 10, 2024
qgallouedec
added a commit
that referenced
this pull request
Dec 10, 2024
* `model_config` -> `model_args` * sort
qgallouedec
added a commit
that referenced
this pull request
Dec 13, 2024
* Refactor main function in dpo.py * Update setup.py and add cli.py * Add examples to package data * style * Refactor setup.py file * Add new file t.py * Move dpo to package * Update MANIFEST.in and setup.py, refactor trl/cli.py * Add __init__.py to trl/scripts directory * Add license header to __init__.py * File moved instruction * Add Apache License and update file path * Move dpo.py to new location * Refactor CLI and DPO script * Refactor import structure in scripts package * env * rm config from chat arg * rm old cli * chat init * test cli [skip ci] * Add `datast_config_name` to `ScriptArguments` (#2440) * add missing arg * Add test cases for 'trl sft' and 'trl dpo' commands * Add sft.py script and update cli.py to include sft command * Move sft script * chat * style [ci skip] * kto * rm example config * first step on doc * see #2442 * see #2443 * fix chat windows * ©️ Copyrights update (#2454) * First changes * Other files * Finally * rm comment * fix nashmd * Fix example * Fix example [ci skip] * 💬 Fix chat for windows (#2443) * fix chat for windows * add some tests back * Revert "add some tests back" This reverts commit 350aef5. * 🆔 Add `datast_config` to `ScriptArguments` (#2440) * datast_config_name * Update trl/utils.py [ci skip] * sort import * typo [ci skip] * Trigger CI * Rename `dataset_config_name` to `dataset_config` * 🏎 Fix deepspeed preparation of `ref_model` in `OnlineDPOTrainer` (#2417) * Remove unused deepspeed code * add model prep back * add deepspeed even if it doesn't work * rm old code * Fix config name * Remove `make dev` in favor of `pip install -e .[dev]` * Update script paths and remove old symlink related things * Fix chat script path [ci skip] * style
qgallouedec
added a commit
that referenced
this pull request
Feb 7, 2025
* initial commit * update * Refactor SFTTrainer and SFTConfig * Update SFTConfig class in sft_config.py * Fix SFTConfig torch_dtype validation and dataset preprocessing flag * Refactor dataset mapping and conversion * Refactor dataset mapping in SFTTrainer * Fix SFTTrainerTester unit test by removing unnecessary code * Remove unused variables and update tokenization logic * Remove pack_dataset function * Add deprecation warning for tokenizer in SFTTrainer constructor * add docstring back * Update model parameter type annotation * Update SFTTrainer class definition * style * preprocess_dataset -> _prepare_dataset * Retro compat * Update formatting_func type hint in SFTTrainer constructor * typo * better comment * simplify tokenize row * Fix type hint for peft_config * fix doc * Add pack_examples function to `test_data_utils.py` * promote pack_examples and document * improve doc * Add new SFTTrainerTester2 class for testing * test was reversed * ©️ Copyrights update (#2454) * First changes * Other files * Finally * rm comment * fix nashmd * Fix example * Fix example * 💬 Fix chat for windows (#2443) * fix chat for windows * add some tests back * Revert "add some tests back" This reverts commit 350aef5. * 🆔 Add `datast_config` to `ScriptArguments` (#2440) * datast_config_name * Update trl/utils.py * sort import * typo * Trigger CI * Rename `dataset_config_name` to `dataset_config` * 🏎 Fix deepspeed preparation of `ref_model` in `OnlineDPOTrainer` (#2417) * Remove unused deepspeed code * add model prep back * add deepspeed even if it doesn't work * rm old code * 👯 Standardize `model_args` (#2442) * `model_config` -> `model_args` * sort * refactor config * drop skip prepare dataset * add sep to packing * drop prompt-completion for now * Revert "drop prompt-completion for now" This reverts commit 16ef195. * Revert "add sep to packing" This reverts commit dc84d08. * Revert "drop skip prepare dataset" This reverts commit d2ee070. * Revert "refactor config" This reverts commit f732aa8. * Format * Update doc-builder workflow to use specific commit sha * add peft edge cases * no logits when using liger * remove unused columns * proper handle of prompt-completion * trick to keep messages * fix messages missing * for Liger kernel, ensure only input_ids is present * packing and liger are compatible * shinny doc and final nits * another nit * refactor config and doc * re add truncation * fix ci * drop deprecated params in tests * fix link * fix config docstring --------- Co-authored-by: Kashif Rasul <kashif.rasul@gmail.com>
yxliu-TAMU
pushed a commit
to mincheolseong/ECEN743-GRPO-Project-Proposal
that referenced
this pull request
Apr 20, 2025
* `model_config` -> `model_args` * sort
yxliu-TAMU
pushed a commit
to mincheolseong/ECEN743-GRPO-Project-Proposal
that referenced
this pull request
Apr 20, 2025
* Refactor main function in dpo.py * Update setup.py and add cli.py * Add examples to package data * style * Refactor setup.py file * Add new file t.py * Move dpo to package * Update MANIFEST.in and setup.py, refactor trl/cli.py * Add __init__.py to trl/scripts directory * Add license header to __init__.py * File moved instruction * Add Apache License and update file path * Move dpo.py to new location * Refactor CLI and DPO script * Refactor import structure in scripts package * env * rm config from chat arg * rm old cli * chat init * test cli [skip ci] * Add `datast_config_name` to `ScriptArguments` (huggingface#2440) * add missing arg * Add test cases for 'trl sft' and 'trl dpo' commands * Add sft.py script and update cli.py to include sft command * Move sft script * chat * style [ci skip] * kto * rm example config * first step on doc * see huggingface#2442 * see huggingface#2443 * fix chat windows * ©️ Copyrights update (huggingface#2454) * First changes * Other files * Finally * rm comment * fix nashmd * Fix example * Fix example [ci skip] * 💬 Fix chat for windows (huggingface#2443) * fix chat for windows * add some tests back * Revert "add some tests back" This reverts commit 350aef5. * 🆔 Add `datast_config` to `ScriptArguments` (huggingface#2440) * datast_config_name * Update trl/utils.py [ci skip] * sort import * typo [ci skip] * Trigger CI * Rename `dataset_config_name` to `dataset_config` * 🏎 Fix deepspeed preparation of `ref_model` in `OnlineDPOTrainer` (huggingface#2417) * Remove unused deepspeed code * add model prep back * add deepspeed even if it doesn't work * rm old code * Fix config name * Remove `make dev` in favor of `pip install -e .[dev]` * Update script paths and remove old symlink related things * Fix chat script path [ci skip] * style
yxliu-TAMU
pushed a commit
to mincheolseong/ECEN743-GRPO-Project-Proposal
that referenced
this pull request
Apr 20, 2025
* initial commit * update * Refactor SFTTrainer and SFTConfig * Update SFTConfig class in sft_config.py * Fix SFTConfig torch_dtype validation and dataset preprocessing flag * Refactor dataset mapping and conversion * Refactor dataset mapping in SFTTrainer * Fix SFTTrainerTester unit test by removing unnecessary code * Remove unused variables and update tokenization logic * Remove pack_dataset function * Add deprecation warning for tokenizer in SFTTrainer constructor * add docstring back * Update model parameter type annotation * Update SFTTrainer class definition * style * preprocess_dataset -> _prepare_dataset * Retro compat * Update formatting_func type hint in SFTTrainer constructor * typo * better comment * simplify tokenize row * Fix type hint for peft_config * fix doc * Add pack_examples function to `test_data_utils.py` * promote pack_examples and document * improve doc * Add new SFTTrainerTester2 class for testing * test was reversed * ©️ Copyrights update (huggingface#2454) * First changes * Other files * Finally * rm comment * fix nashmd * Fix example * Fix example * 💬 Fix chat for windows (huggingface#2443) * fix chat for windows * add some tests back * Revert "add some tests back" This reverts commit 350aef5. * 🆔 Add `datast_config` to `ScriptArguments` (huggingface#2440) * datast_config_name * Update trl/utils.py * sort import * typo * Trigger CI * Rename `dataset_config_name` to `dataset_config` * 🏎 Fix deepspeed preparation of `ref_model` in `OnlineDPOTrainer` (huggingface#2417) * Remove unused deepspeed code * add model prep back * add deepspeed even if it doesn't work * rm old code * 👯 Standardize `model_args` (huggingface#2442) * `model_config` -> `model_args` * sort * refactor config * drop skip prepare dataset * add sep to packing * drop prompt-completion for now * Revert "drop prompt-completion for now" This reverts commit 16ef195. * Revert "add sep to packing" This reverts commit dc84d08. * Revert "drop skip prepare dataset" This reverts commit d2ee070. * Revert "refactor config" This reverts commit f732aa8. * Format * Update doc-builder workflow to use specific commit sha * add peft edge cases * no logits when using liger * remove unused columns * proper handle of prompt-completion * trick to keep messages * fix messages missing * for Liger kernel, ensure only input_ids is present * packing and liger are compatible * shinny doc and final nits * another nit * refactor config and doc * re add truncation * fix ci * drop deprecated params in tests * fix link * fix config docstring --------- Co-authored-by: Kashif Rasul <kashif.rasul@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
ModelConfiginstances are currently named withmodel_argsandmodel_config. This PR standardizes the naming tomodel_argsSame as #2082 for
ModelConfigBefore submitting
Pull Request section?
to it if that's the case.
documentation guidelines.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.