Skip to content

Conversation

stevhliu
Copy link
Member

This PR adds some updates to the contribution guide such as including a brief section for adding new documentation and being able to preview the docs once you successfully open a pull request.

@stevhliu stevhliu requested a review from sgugger October 18, 2022 00:08
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 18, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! I pointed out the places where the guide was outdated or where your modifications change too much the meaning of the message, but LGTM otherwise!

@stevhliu stevhliu requested a review from sgugger October 18, 2022 20:35
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating!

@stevhliu stevhliu merged commit 3267080 into huggingface:main Oct 19, 2022
@stevhliu stevhliu deleted the update-contribute branch October 19, 2022 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants