Check authorized imports in LocalPythonInterpreter constructor #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed TODO from comment
| @@ -1529,7 +1530,12 @@ def __init__( | |||
| **tools, | |||
| **BASE_PYTHON_TOOLS.copy(), | |||
| } | |||
| # TODO: assert self.authorized imports are all installed locally | |||
| # assert self.authorized imports are all installed locally | |||
| missing_modules = [imp for imp in self.authorized_imports if find_spec(imp) is None] | |||
There was a problem hiding this comment.
There's an issue here if additional_authorized_imports includes "*". A check should be added to ensure "*" is working properly.
|
@AngeloKiriakoulis good catch on the wildcard import. I added a test case for the wildcard import and fixed the implementation. Ran make style on changed files. |
aymeric-roucher
approved these changes
Jan 30, 2025
|
any chance of getting this merged? Alternatively, I would just close and delete this MR. |
albertvillanova
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking if authorized_imports exist was marked as TODO in the comment.
This MR implements this functionality and adds tests.
Also adds a test option to the makefile to skip the tests of DocStrings, which require API keys.