Bug Fix: Fix continue semantics of LocalPythonExecutor #1645
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug:
continue
treated aspass
within for loops with LocalPythonExecutorFix
The proposed fix is to make continue statements break from the current execution of the loop body and continue to the next loop iteration.
Problem Description
The local python interpreter incorrectly handles continue statements within
for
loops. Acontinue
statement is treated as apass
statement which silently breaks normal Python semantics.Minimal Bug Reproduction:
Output:
The output from the above code is incorrect based on the semantics of a Python
continue
statement which should skip to the next loop iteration rather than execute the rest of the loop body.