BUG FIX: AmazonBedrockServerModel crashes when thinking mode is enabled #1632
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
AmazonBedrockServerModel is trying to access the wrong response field when Claude thinking mode is enabled. I believe this might be the case with other bedrock models when thinking mode is enabled too.
The problem is the AmazonBedrockServerModel assumes the response is always the 'text' field of the first element [0] of response["output"]["message"]["content"] but that is not the case when thinking mode is enabled.
Steps to reproduce
{"thinking": {"type": "enabled", "budget_tokens": 4096}}
asadditionalModelRequestFields
in the constructor ofAmazonBedrockServerModel
.Reproduce
Expected behavior
Dont crash and provide the code and solution
Environment:
Commit: 84e5e8c
Other context is irrelevant
Checklist