Make validate_tool_arguments raise exception instead of returning error string #1634
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
validate_tool_arguments
raise exception instead of returning error string, improving code design and following Python conventions.Changes Made
validate_tool_arguments
: Now raisesValueError
andTypeError
directly instead of returning error message stringsRaises
section documenting all possible exceptionstest_validate_tool_arguments
andtest_validate_tool_arguments_nullable
to usepytest.raises()
for exception testingexecute_tool_call
now has cleaner exception handling with proper exception chaining usingfrom e
Benefits
ValueError
/TypeError
) following established conventionsfrom e
Exception Types
ValueError
: For invalid argument values (missing required args, args not in schema, etc.)TypeError
: For type mismatches that cannot be convertedThe caller catches these exceptions and reraises them as
AgentToolCallError
with proper context, maintaining the existing error handling flow while improving the internal design.