Skip to content

Conversation

aymeric-roucher
Copy link
Collaborator

@aymeric-roucher aymeric-roucher commented Jul 26, 2025

Currently in ToolCallingAgent, memory_step.model_output is augmented by appending a formatted string representing every tool call.

  • I think it is not necessary. It was originally intended to better visualize tool calls in Gradio interfaces. But these interfaces now visualize the content of step.tool_calls directly
  • it has the unintended effect of showing LLMs a wrong history of past messages. The artifact that it created for me is that the model would see tool call descriptions in history, thus it would start to write itself Tool call {id}: calling {name} with {arguments} instead of using JSON action format.

Thus we can remove it!

Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@albertvillanova albertvillanova merged commit f8f314d into main Jul 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants