Skip to content

fix(Tool.forward): raise the NotImplementedError instead of return #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2025
Merged

fix(Tool.forward): raise the NotImplementedError instead of return #1628

merged 1 commit into from
Jul 29, 2025

Conversation

HairlessVillager
Copy link
Contributor

Hello! Although returning an Exception is grammatically possible, based on the context, it should be raising this Exception. I guess there might have been an accidental mistake here, so I corrected it.

albertvillanova
albertvillanova approved these changes Jul 29, 2025
View reviewed changes
Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good catch!

@albertvillanova albertvillanova merged commit 6826823 into huggingface:main Jul 29, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertvillanova albertvillanova albertvillanova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HairlessVillager @albertvillanova