Skip to content

Fix a kwargs error in LocalPythonExecutor #1583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 20, 2025
Merged

Fix a kwargs error in LocalPythonExecutor #1583

merged 8 commits into from
Jul 20, 2025

Conversation

aymeric-roucher
Copy link
Collaborator

@aymeric-roucher aymeric-roucher commented Jul 19, 2025 •
edited
Loading

Kwargs were incorrectly processed in LocalPythonExecutor, so calling a function like function(**execution_args) would fail : this PR fixes it.

albertvillanova
albertvillanova approved these changes Jul 20, 2025
View reviewed changes
Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and the test! 🤗

Just added some more tests and reverted the unrelated only-formatting changes.

@albertvillanova albertvillanova merged commit 23a4dcd into main Jul 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertvillanova albertvillanova albertvillanova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aymeric-roucher @albertvillanova