Skip to content

🌐 [i18n-KO] Translated index.md to Korean #1581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 29, 2025

Conversation

FacerAin
Copy link
Contributor

@FacerAin FacerAin commented Jul 19, 2025

What does this PR do?

Hello 😊
Thank you for the amazing Smolagents project.
I would like to contribute to the Korean translation project for the Korean developer ecosystem.
In this regard, I have created the ko directory and completed the translation of index.md.

Part of huggingface/transformers#20179

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

May you please review this PR?
@4N3MONE, @yijun-lee, @jungnerd , @harheem

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@albertvillanova

Copy link
Contributor Author

@FacerAin FacerAin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

  1. ko 디렉토리 생성
  2. toctree 추가
  3. index.md 번역을 수행하였습니다.

관련하여 헷갈리거나 의논이 필요한 부분은 Discussion Point를 남겨두었습니다.
소중한 시간 내어주셔서 감사합니다 😊😊

@FacerAin FacerAin requested review from 4N3MONE and yijun-lee July 23, 2025 00:27
Copy link
Contributor

@yijun-lee yijun-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은 것 같습니다. 수고 많으셨어요 ㅎㅎ

Copy link

@jungnerd jungnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나머지는 번역 모두 좋아보입니다! 감사합니다!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

- Add [[smolagents]] for ToC

Co-authored-by: Yijun Lee <119404328+yijun-lee@users.noreply.github.com>
@FacerAin FacerAin marked this pull request as ready for review July 26, 2025 23:12
Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It looks good to me.

@albertvillanova albertvillanova merged commit b860584 into huggingface:main Jul 29, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants