Fix: Prevent empty additional_args from being added to agent prompt #1566
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes empty
additional_args
dictionaries being added to agent prompts unnecessarily. The current implementation checks ifadditional_args
is notNone
, but doesn't verify if the dictionary actually contains any items.Problem
ToolCallingAgent
was receiving Python arguments instructions despite not being able to execute Python codeExample prompt when using a nested multi agent strcuture like
CodeAgent
->ToolCallingAgent
(Managed Agent)Solution
Changed the condition from
if additional_args is not None
toif additional_args
to only add the additional arguments message when the dictionary is both not None and not empty.Edit: Quality / format checks and tests run suscessfully.