Skip to content

Fix Access of content Field in ChatMessage Object #1533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 8, 2025
Merged

Fix Access of content Field in ChatMessage Object #1533

merged 2 commits into from
Jul 8, 2025

Conversation

mdr223
Copy link
Contributor

@mdr223 mdr223 commented Jul 7, 2025

This PR contains a one-line fix for #1532.

@mdr223 mdr223 mentioned this pull request Jul 7, 2025
Closed
albertvillanova
albertvillanova approved these changes Jul 8, 2025
View reviewed changes
Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good catch!

I just updated the corresponding test (that was wrong before your fix, anyway).

As commented in the issue, I think this bug was introduced after the breaking change replacement of Message (TypedDict) with ChatMessage (dataclass), done in:

@albertvillanova albertvillanova merged commit 5fd07f9 into huggingface:main Jul 8, 2025
3 checks passed
@albertvillanova albertvillanova mentioned this pull request Jul 8, 2025
Merged
@albertvillanova albertvillanova linked an issue Jul 8, 2025 that may be closed by this pull request
[BUG] ChatMessage content Attribute Accessed Incorrectly #1532
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertvillanova albertvillanova albertvillanova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] ChatMessage content Attribute Accessed Incorrectly
2 participants
@mdr223 @albertvillanova