Add adapter_kwargs parameter to MCPClient #1528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertvillanova
requested changes
Jul 7, 2025
There was a problem hiding this comment.
Thanks for the addition, @LucasDltg.
However, please note that the client_session_timeout_seconds was only introduced in mcpadapt-0.1.10, whereas we currently support mcpadapt>=0.1.8.
To maintain compatibility with older versions, maybe we could expose a more generic adapter_kwargs param instead and pass it through to MCPAdapt, so users can customize it depending on their installed version.
Let me know what you think.
|
Sounds good to me. I have updated the PR. |
albertvillanova
requested changes
Jul 7, 2025
src/smolagents/mcp_client.py
Outdated
| @@ -79,6 +79,7 @@ class MCPClient: | |||
| def __init__( | |||
| self, | |||
| server_parameters: "StdioServerParameters" | dict[str, Any] | list["StdioServerParameters" | dict[str, Any]], | |||
| adapter_kwargs: dict[str, Any] | |||
There was a problem hiding this comment.
You made this parameter required. Could you please make it optional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.