Bug Fix: KeyError when agent reaches max steps with image input #1525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an agent reaches max steps with image input, the error handling in provide_final_answer was returning a plain string as content instead of the expected list format. This caused a KeyError when models.py tried to pop('image') from the message content during processing.
The fix changes the error message format from a plain string to a properly structured list with type annotation, matching the expected ChatMessage content format.
Fixes huggingface#1524
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When an agent reaches max steps with image input, a KeyError occurs because the error handling in
provide_final_answerreturns a plain string instead of the expected listformat. This causes
models.pyto fail when trying topop("image")from the message content.Solution
Changed the error message format in
agents.py:826from a plain string to a properly structured list with type annotation, matching the expected ChatMessage content format.Testing
make quality)make style)Related Issue
Fixes #1524