Enable image output for Tool.from_space #1510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requesting review from @A-Mahla since we have been discussing how to integrate different tools! (failing wikipedia tests are unrelated) |
A-Mahla
approved these changes
Jul 7, 2025
Comment on lines
-645
to
657
| return output[ | ||
| if isinstance(output[1], str): | ||
| raise ValueError("The space returned this message: " + output[1]) | ||
| output = output[ | ||
| 0 | ||
| ] # Sometime the space also returns the generation seed, in which case the result is at index 0 | ||
| IMAGE_EXTENTIONS = [".png", ".jpg", ".jpeg", ".gif", ".webp"] | ||
| AUDIO_EXTENTIONS = [".mp3", ".wav", ".ogg", ".m4a", ".flac"] | ||
| if isinstance(output, str) and any([output.endswith(ext) for ext in IMAGE_EXTENTIONS]): | ||
| output = AgentImage(output) | ||
| elif isinstance(output, str) and any([output.endswith(ext) for ext in AUDIO_EXTENTIONS]): | ||
| output = AgentAudio(output) | ||
| return output |
There was a problem hiding this comment.
It’s not clear what type output is exactly. AgentImage | AgentAudio | str ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gradio_client.Client.predict()returns path to generated images/audio files instead of the real image/audio object: this PR fixes it. It also adds testing to make sure that agents do return image objects when they callfinal_answeron an image.