Implement rate limit mechanism in DuckDuckGoSearchTool #1515
Conversation
| @@ -104,9 +104,12 @@ class DuckDuckGoSearchTool(Tool): | |||
| inputs = {"query": {"type": "string", "description": "The search query to perform."}} | |||
| output_type = "string" | |||
|
|
|||
| def __init__(self, max_results=10, **kwargs): | |||
| def __init__(self, max_results=10, rate_limit: float | None = 1.0, **kwargs): | |||
There was a problem hiding this comment.
So the default rate limit will be to wait 1s between calls, not 0?
There was a problem hiding this comment.
Apparently, users reported they get a rate limit error: see the associated issue:
However, I don't know what the exact value of the rate limit implemented on the DuckDuckGo Search side is. I tried this value, but we could tweak it if users have a better guess.
|
@albertvillanova maybe it would be worth switching to rate limit per minute to conform with what we use for models? |
|
@aymeric-roucher thanks for the suggestion. I think using a rate limit expressed in queries per second is more widely used in the case of web search APIs, since their resource usage is generally lower than that of model inference. This makes finer-grained control via per-second limits more appropriate. While we do not have the exact information for DuckDuckGo, Brave Search API documents their rate limits in queries per second: https://brave.com/search/api/
To make this explicit and reduce ambiguity, maybe I could rename the parameter |
Implement rate limit mechanism in
DuckDuckGoSearchTool.Follow-up to:
Fix #1501.