Revert removal of the last message from memory_messages during planning #1454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In this case, let's go for the simple fix you propose and just undo the removal the latest message, no need for other modifications IMO! |
255b23a to
5381a1e
Compare
|
I updated the branch. This PR basically just undo the change and improved the unit test. Feel free to close this PR if the fix is included somewhere else. |
albertvillanova
requested changes
Jun 24, 2025
albertvillanova
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous change I did to save token usage is wrong as cyzus pointed out. I reverted the change, and updated the test to reflect the scenario I didn't think of.
The last message in the memory_messages is not necessarily the task.
Maybe we can filter the memory_message if we don't want to send the same task twice or we can change the pre_update_plan prompt to not include the task.
Fix bug introduced in: