Update prompts to avoid confusion: search -> web_search and wiki -> wiki_search #1403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…earch As outlined in huggingface#1292 ``` Code execution failed at line 'distance_earth_mars = search(query="distance between Earth and Mars")' due to: InterpreterError: Forbidden function evaluation: 'search' is not among the explicitly allowed tools or defined/imported in the preceding code ``` The prompt is making the agent think that `search` should be used when Hf tools [DuckDuckGoSearchTool](https://github.com/huggingface/smolagents/blob/522a315c955a8b0649238d835c23353d8ec54434/src/smolagents/default_tools.py#L102), [GoogleSearchTool](https://github.com/huggingface/smolagents/blob/522a315c955a8b0649238d835c23353d8ec54434/src/smolagents/default_tools.py#L127), [WebSearchTool](https://github.com/huggingface/smolagents/blob/522a315c955a8b0649238d835c23353d8ec54434/src/smolagents/default_tools.py#L214) use `web_search`. I've also updated the [WikipediaSearchTool](https://github.com/huggingface/smolagents/blob/522a315c955a8b0649238d835c23353d8ec54434/src/smolagents/default_tools.py#L410) prompt to call `wikipedia_search` instead of `wiki` since it appears to have a similar issue.
… applied in `code_agent.yaml`
Fixed `code_agent.yaml` to use wiki search instead of wiki search in rules for wikipedia search.
I have left `toolcalling_agent.yaml` alone as I'm not 100% sure whether that has the same issue or whether it was intentional.
```
Task: "Which city has the highest population , Guangzhou or Shanghai?"
Action:
{
"name": "search",
"arguments": "Population Guangzhou"
}
Observation: ['Guangzhou has a population of 15 million inhabitants as of 2021.']
Action:
{
"name": "search",
"arguments": "Population Shanghai"
}
Observation: '26 million (2019)'
Action:
{
"name": "final_answer",
"arguments": "Shanghai"
}
```
albertvillanova
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in #1292
The prompt is making the agent think that
searchshould be used when HF tools DuckDuckGoSearchTool, GoogleSearchTool, WebSearchTool useweb_search.I've also updated the WikipediaSearchTool prompt to call
wikipedia_searchinstead ofwikisince it appears to have a similar issue.Note: I think the same issue is present in toolcalling_agent.yaml but I'm not 100% sure if this is intentional or not: There are tools that don't exist in this repo referenced in other places.