Skip to content

Make docs neutral about agent types #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 28, 2025
Merged

Make docs neutral about agent types #1376

merged 3 commits into from
May 28, 2025

Conversation

julien-c
Copy link
Member

Summary

  • update README to treat CodeAgent and ToolCallingAgent evenly
  • adjust docs to present both agent types on equal footing
  • tone down opinionated language in docs

Testing

  • make quality
  • make test (fails: ModuleNotFoundError: No module named 'smolagents')

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

aymeric-roucher
aymeric-roucher approved these changes May 23, 2025
View reviewed changes
Copy link
Collaborator

@aymeric-roucher aymeric-roucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @julien-c!

I think it would be worth keeping a mention that there's some work needed on our side to improve ToolCallingAgent for some models, for instance several inference providers do not reliably support neither structured generation nor tool calling yet (internal conversation here)

@aymeric-roucher aymeric-roucher merged commit 934a6d1 into main May 28, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aymeric-roucher aymeric-roucher aymeric-roucher approved these changes

@albertvillanova albertvillanova Awaiting requested review from albertvillanova

Assignees
No one assigned
Labels
codex
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julien-c @HuggingFaceDocBuilderDev @aymeric-roucher