Skip to content

Conversation

zbloss
Copy link
Contributor

@zbloss zbloss commented May 15, 2025

Implements Issue #1332

I'm not sure which branch to merge into, so please advise!

Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a test not passing after your change.

Maybe better to make the new params optional.

Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just made the new params optional to include this PR in today release!
Thanks again!

@albertvillanova albertvillanova merged commit 4c9ade8 into huggingface:main May 16, 2025
3 checks passed
@albertvillanova albertvillanova linked an issue May 16, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable local web agents via api_base and api_key
2 participants