Skip to content

Fix thought yield in GradioUI for streaming and non-streaming #1311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 9, 2025
Merged

Fix thought yield in GradioUI for streaming and non-streaming #1311

merged 2 commits into from
May 9, 2025

Conversation

albertvillanova
Copy link
Member

@albertvillanova albertvillanova commented May 9, 2025 •
edited
Loading

Fix thought yield in GradioUI for streaming and non-streaming.

Before, thought was duplicated in streaming and missing in non-streaming. The issue was introduced in:

Fix #1305.

@aymeric-roucher should we make a patch release?

aymeric-roucher
aymeric-roucher approved these changes May 9, 2025
View reviewed changes
Copy link
Collaborator

@aymeric-roucher aymeric-roucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @albertvillanova !

@albertvillanova albertvillanova merged commit a9d3c67 into huggingface:main May 9, 2025
3 checks passed
@albertvillanova albertvillanova deleted the fix-1305 branch May 9, 2025 11:43
@albertvillanova albertvillanova mentioned this pull request May 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aymeric-roucher aymeric-roucher aymeric-roucher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Broken gradio display after stream output feat
2 participants
@albertvillanova @aymeric-roucher