Skip to content

Fix deprecation of HfApiModel #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 12, 2025
Merged

Fix deprecation of HfApiModel #1315

merged 4 commits into from
May 12, 2025

Conversation

albertvillanova
Copy link
Member

@albertvillanova albertvillanova commented May 12, 2025 •
edited
Loading

Fix deprecation of HfApiModel:

  • raise FutureWarning instead of DeprecationWarning: the latter is not intended for end users and is filtered out by default
  • fix warning message specifying in which version the class will be removed
  • fix tests: testing deprecated HfApiModel raises deprecation warnings in the CI
  • explicitly test HfApiModel raises deprecation warning when instantiated

Follow up to:

@albertvillanova albertvillanova merged commit 1e0e6a4 into huggingface:main May 12, 2025
3 checks passed
@albertvillanova albertvillanova deleted the fix-deprecated-hf-api-model branch May 12, 2025 08:41
@albertvillanova albertvillanova mentioned this pull request Jun 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-c julien-c julien-c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albertvillanova @julien-c