Skip to content

Fix remote executor send_tools to skip pip install on empty package list #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2025
Merged

Fix remote executor send_tools to skip pip install on empty package list #1273

merged 2 commits into from
Apr 30, 2025

Conversation

albertvillanova
Copy link
Member

Fix remote executor send_tools to skip pip install on empty package list.

We were getting an error log:

ERROR: You must give at least one requirement to install (see "pip help install")

Now we first check if there are new requirements before running pip install:

f"!pip install {' '.join(packages_to_install)}\n"

aymeric-roucher
aymeric-roucher approved these changes Apr 30, 2025
View reviewed changes
Copy link
Collaborator

@aymeric-roucher aymeric-roucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you Albert!

@albertvillanova albertvillanova merged commit c9513b9 into huggingface:main Apr 30, 2025
3 checks passed
@albertvillanova albertvillanova deleted the fix-remote-send-tools branch April 30, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aymeric-roucher aymeric-roucher aymeric-roucher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albertvillanova @aymeric-roucher