Skip to content

Conversation

merveenoyan
Copy link
Contributor

No description provided.

Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks!

Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@julien-c
Copy link
Member

ah, note that this PR probably requires an upgrade to the huggingface_hub dependency in smolagents, to v0.30.0+, cc @Wauplin and @hanouticelina

Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, @julien-c!

The bill_to param was added in v0.30.0: huggingface/huggingface_hub@cb315d9

And current lower bound of huggingface_hub in smolagents is 0.28.0.

@merveenoyan
Copy link
Contributor Author

@albertvillanova I'll just bump and see if there's any tests not passing

@merveenoyan merveenoyan merged commit 1e2cdcd into main Apr 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants