Skip to content

Fix Loading GAIA dataset #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 30, 2025
Merged

Fix Loading GAIA dataset #1266

merged 14 commits into from
Apr 30, 2025

Conversation

aymeric-roucher
Copy link
Collaborator

Continues #499

@aymeric-roucher aymeric-roucher changed the title Fix load gaia 2 Fix Loading GAIA dataset Apr 29, 2025
@aymeric-roucher aymeric-roucher marked this pull request as ready for review April 29, 2025 16:03
@aymeric-roucher aymeric-roucher requested a review from A-Mahla April 29, 2025 16:04
Copy link
Member

@A-Mahla A-Mahla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @aymeric-roucher ! Thanks

Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@@ -38,12 +38,13 @@ def get_single_file_description(file_path: str, question: str, visual_inspection
)
return file_description
elif file_extension in ["pdf", "xls", "xlsx", "docx", "doc", "xml"]:
file_description = f" - Attached document: {file_path}"
image_path = file_path.split(".")[0] + ".png"
if os.path.exists(image_path):
Copy link
Collaborator Author

@aymeric-roucher aymeric-roucher Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@A-Mahla could you check that this substituttion mechanism works?

@aymeric-roucher aymeric-roucher merged commit 08319f2 into main Apr 30, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants