Remove dead code related to non-CompletionDelta streaming results #1248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertvillanova
commented
Apr 25, 2025
Comment on lines
-1295
to
+1297
| if isinstance(event, CompletionDelta): | ||
| if event.content is not None: | ||
| output_text += event.content | ||
| live.update(Markdown(output_text)) | ||
| elif isinstance(event, ToolCall): | ||
| memory_step.tool_calls = [event] | ||
| if event.content is not None: | ||
| output_text += event.content | ||
| live.update(Markdown(output_text)) |
There was a problem hiding this comment.
@aymeric-roucher: streaming always yields CompletionDelta instances, or am I missing something?
There was a problem hiding this comment.
Yes indeed! The handling of specific object for ToolCalls should be let for when/if we activate streaming outputs in ToolCallingAgent
aymeric-roucher
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove dead code related to non-CompletionDelta streaming results.
Follow-up to: