Skip unsupported stop parameter for reasoning models #1211
Conversation
|
The CI error is unrelated: |
src/smolagents/models.py
Outdated
| @@ -307,7 +307,9 @@ def _prepare_completion_kwargs( | |||
|
|
|||
| # Handle specific parameters | |||
| if stop_sequences is not None: | |||
| completion_kwargs["stop"] = stop_sequences | |||
| # Not supported with reasoning models openai/o3 and openai/o4-mini | |||
| if self.model_id.split("/")[-1] not in ["o3", "o4-mini"]: | |||
There was a problem hiding this comment.
I checked the API, indeed these models don't seem to have any argument for stop sequences, really strange IMO not to propose this.
There was a problem hiding this comment.
yeah... thanks guys!
There was a problem hiding this comment.
@albertvillanova @aymeric-roucher
actually I think the fix above is not working if people specify model versions a la o4-mini-2025-04-16
| if self.model_id.split("/")[-1] not in ["o3", "o4-mini"]: | |
| # Handle specific parameters | |
| if stop_sequences is not None: | |
| # Not supported with reasoning models openai/o3 and openai/o4-mini | |
| if ("o3" in self.model_id.split("/")[-1] and "o3-mini" not in self.model_id.split("/")[-1]) or "o4-mini" in self.model_id.split("/")[-1]: | |
| completion_kwargs.pop("stop", None) | |
| else: | |
| completion_kwargs["stop"] = stop_sequences |
There was a problem hiding this comment.
Yes. For reference: https://platform.openai.com/docs/api-reference/chat/create#chat-create-stop
stop: string / array / null, Optional, Defaults to null
Not supported with latest reasoning models
o3ando4-mini.Up to 4 sequences where the API will stop generating further tokens. The returned text will not contain the stop sequence.
src/smolagents/models.py
Outdated
| @@ -307,7 +307,9 @@ def _prepare_completion_kwargs( | |||
|
|
|||
| # Handle specific parameters | |||
| if stop_sequences is not None: | |||
| completion_kwargs["stop"] = stop_sequences | |||
| # Not supported with reasoning models openai/o3 and openai/o4-mini | |||
| if self.model_id.split("/")[-1] not in ["o3", "o4-mini"]: | |||
There was a problem hiding this comment.
@albertvillanova @aymeric-roucher
actually I think the fix above is not working if people specify model versions a la o4-mini-2025-04-16
| if self.model_id.split("/")[-1] not in ["o3", "o4-mini"]: | |
| # Handle specific parameters | |
| if stop_sequences is not None: | |
| # Not supported with reasoning models openai/o3 and openai/o4-mini | |
| if ("o3" in self.model_id.split("/")[-1] and "o3-mini" not in self.model_id.split("/")[-1]) or "o4-mini" in self.model_id.split("/")[-1]: | |
| completion_kwargs.pop("stop", None) | |
| else: | |
| completion_kwargs["stop"] = stop_sequences |
|
Good catch, @benediktstroebl! We should handle model snapshots (versions) as well. |
Skip unsupported stop parameter for reasoning models: o3 and o4-mini
Fix #1210.