CI: Simplify testing by running all tests in a single command #1218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| run: | | ||
| pytest ./tests/test_default_tools.py | ||
| if: ${{ success() || failure() }} | ||
| pytest ./tests/ |
There was a problem hiding this comment.
Won't that also run doc tests (pytest ./tests/test_all_docs.py) that we wanted to exclude?
There was a problem hiding this comment.
Good catch! Let me think how to avoid this... 🤔
There was a problem hiding this comment.
I checked the CI run and the test_all_docs.py were skipped: https://github.com/huggingface/smolagents/actions/runs/14516429844/job/40726458962
tests/test_all_docs.py::TestDocs::test_single_doc[guided_tour] SKIPPED
tests/test_all_docs.py::TestDocs::test_single_doc[index] SKIPPED (re...)
tests/test_all_docs.py::TestDocs::test_single_doc[intro_agents] SKIPPED
tests/test_all_docs.py::TestDocs::test_single_doc[react] SKIPPED (re...)
tests/test_all_docs.py::TestDocs::test_single_doc[tools0] SKIPPED (r...)
tests/test_all_docs.py::TestDocs::test_single_doc[secure_code_execution] SKIPPED
tests/test_all_docs.py::TestDocs::test_single_doc[inspect_runs] SKIPPED
tests/test_all_docs.py::TestDocs::test_single_doc[memory] SKIPPED (r...)
tests/test_all_docs.py::TestDocs::test_single_doc[building_good_agents] SKIPPED
tests/test_all_docs.py::TestDocs::test_single_doc[tools1] SKIPPED (r...)
tests/test_all_docs.py::TestDocs::test_single_doc[models] SKIPPED (r...)
tests/test_all_docs.py::TestDocs::test_single_doc[agents] SKIPPED (r...)
tests/test_all_docs.py::TestDocs::test_single_doc[text_to_sql] SKIPPED
tests/test_all_docs.py::TestDocs::test_single_doc[multiagents] SKIPPED
tests/test_all_docs.py::TestDocs::test_single_doc[rag] SKIPPED (requ...)
tests/test_all_docs.py::TestDocs::test_single_doc[web_browser] SKIPPED
I checked the test_all_docs.py file and the reason is that these tests are marked with @require_run_all. So no further fix is needed!
aymeric-roucher
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify testing by running all tests in a single command.
This PR simplifies the CI testing by using a single pytest command to run all tests instead of separate commands for each test file.
This change is the foundation for enabling parallel test execution in a future PR (using pytest-xdist or similar tools), which could significantly reduce CI execution time.