Make to_messages methods compatible with qwen vl #1148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d2526e7 to
5831a62
Compare
5831a62 to
e5a116e
Compare
albertvillanova
approved these changes
Apr 5, 2025
| @@ -162,7 +164,7 @@ def create_agent_hierarchy(model: Model): | |||
| max_steps=12, | |||
| verbosity_level=2, | |||
| additional_authorized_imports=AUTHORIZED_IMPORTS, | |||
| planning_interval=4, | |||
| # planning_interval=4, | |||
There was a problem hiding this comment.
Do we no longer need any planning step?
There was a problem hiding this comment.
I rolled this change back!
| @@ -32,6 +32,7 @@ | |||
|
|
|||
| from smolagents import ( | |||
| CodeAgent, | |||
| GoogleSearchTool, | |||
There was a problem hiding this comment.
If you change the available tools, then you should run again for all previous models so their results are comparable.
There was a problem hiding this comment.
This is the same behavior as before: making a call to Serper.dev or Serpapi depending on the user choice. It simply uses our built-in tool instead of the one implemented in the custom SimpleTextBrowser, which makes it better supported.
Co-authored-by: Albert Villanova del Moral <8515462+albertvillanova@users.noreply.github.com>
This was referenced Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.