Implement Tool.from_dict #1006
Merged
Implement Tool.from_dict #1006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
| if "code" not in tool_dict: | ||
| raise ValueError("Tool dictionary must contain 'code' key with the tool source code") | ||
| return cls.from_code(tool_dict["code"], **kwargs) |
There was a problem hiding this comment.
Maybe raise a warning if the tool requirements are not installed locally?
There was a problem hiding this comment.
Thanks for the review.
I would suggest not enforcing that at this stage, as we intentionally allow tools to be defined (either by subclassing Tool or using the @tool decorator) without requiring their dependencies to be installed locally.
One common use case is sending the tool to be executed in a separate environment, such as a Docker container, where the necessary requirements will be installed.
Let me know if you have thoughts or other ideas around this!
aymeric-roucher
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
Tool.from_dict, the inverse of the existingto_dictmethod, allowing tools to be recreated from their dictionary representation.