Skip to content

Add api_key argument in HfApiModel #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 14, 2025

Conversation

aymeric-roucher
Copy link
Collaborator

To extend compatibility with usual api_key argument used in other models, and mimick the api used in hugginface_hub library.

Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@albertvillanova albertvillanova changed the title Add api_token argument in HfApiModel Add api_key argument in HfApiModel Apr 14, 2025
@julien-c
Copy link
Member

can we please stay as close as possible to huggingface_hub's API? It does not make sense to deviate

@aymeric-roucher
Copy link
Collaborator Author

@julien-c do you mean we should not merge this? huggingface_hub's Client has an api_key parameter, so this PR is moving us closer to the huggingface_hub API

Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no it's fine my comment was more general

@aymeric-roucher aymeric-roucher merged commit 1e853a3 into main Apr 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants