Skip to content

Fix off-by-1 error when removing from end of document #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

HennerM
Copy link
Contributor

@HennerM HennerM commented Jan 20, 2024

I encountered a bug where the in-memory document did get out of the sync with my editor, specifically the in-memory document had an additional character at the end that was previously deleted.

This happens because the deletion index was using the get_position_idx which caps the character of a range to the number of chars in the specific line - 1. This is usually okay, but if we delete from the end of the line the Range End is actually designated as end_char + 1.

This resulted in one dangling character at the end when deleting from the end.

The out-of-sync lead to all kinds of underflow and range errors. I tested the change together with a local checkout of llm-vscode, which now behaves as intended when deleting from the end

@McPatate McPatate merged commit 16606e5 into huggingface:main Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants