Skip to content

Metric to EvaluationModule, MetricInfo to EvaluationModuleInfo #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 17, 2022

Conversation

lvwerra
Copy link
Member

@lvwerra lvwerra commented May 17, 2022

This PR renames Metric and MetricInfo to the more generic EvaluationModule and EvaluationModuleInfo to reflect the fact that now also comparisons and measurements can be loaded. Related to the changes in #40.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 17, 2022

The documentation is not available anymore as the PR was closed or merged.

@lvwerra lvwerra requested review from lhoestq and douwekiela May 17, 2022 13:43
@lvwerra
Copy link
Member Author

lvwerra commented May 17, 2022

PS: the tests that fail are due to the fact that the metric scripts on the main branch still use Metric instead of EvaluationModule. Should work once we merge.

@lvwerra lvwerra merged commit f6e6f96 into main May 17, 2022
@lvwerra lvwerra deleted the refactor-metric-to-evaluation branch July 24, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants