Skip to content

Add code example to docstrings #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 23, 2022
Merged

Add code example to docstrings #374

merged 7 commits into from
Dec 23, 2022

Conversation

stevhliu
Copy link
Member

@stevhliu stevhliu commented Dec 2, 2022

I was thinking it might be nice to add a code example to each docstring so users can see exactly how to use a given method when they go to look it up in the API docs. I started with the two methods in the EvaluationModuleInfo class, and if we like this idea, I'll go ahead and add a code example for the rest!

@stevhliu stevhliu requested a review from lvwerra December 2, 2022 01:18
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Dec 2, 2022

The documentation is not available anymore as the PR was closed or merged.

@lvwerra
Copy link
Member

lvwerra commented Dec 7, 2022

Hi @stevhliu, looks great! Thanks for adding! Could you merge main into this branch - updated the CI.

@stevhliu stevhliu marked this pull request as ready for review December 14, 2022 20:04
Copy link
Member

@lvwerra lvwerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for adding this @stevhliu!

@lvwerra lvwerra merged commit 6abb0d5 into huggingface:main Dec 23, 2022
@stevhliu stevhliu deleted the docstring-examples branch December 23, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants