Skip to content

Conversation

Bhavay-2001
Copy link
Contributor

What does this PR do?

Reduces the model sizes in the DIT tests.

Fixes #7677

Before submitting

Who can review?

@sayakpaul

@Bhavay-2001 Bhavay-2001 changed the title [Tests] reduce the model size in the dance diffusion test [Tests] reduce the model size in the dit test May 10, 2024
@Bhavay-2001
Copy link
Contributor Author

Hi @sayakpaul, can you pls review.

@sayakpaul
Copy link
Member

Why are you deleting tests/pipelines/dance_diffusion/test_dance_diffusion.py?

@Bhavay-2001
Copy link
Contributor Author

Hi sorry, I thought I added the test_dance_diffusion.py file on which I was working locally.

@Bhavay-2001
Copy link
Contributor Author

Hi @sayakpaul, can you pls review this once? Thanks

num_attention_heads=2,
in_channels=4,
out_channels=8,
out_channels=4,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be 8 as that is how guidance is formulated in DiT.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted and updated.

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Left a comment.

@Bhavay-2001
Copy link
Contributor Author

Hi @sayakpaul, can you pls review this.
Thanks

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues that haven't received updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tests] help us speed up the fast pipeline tests
2 participants