Minor modification to support DC-AE-turbo #12169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-r-r-o-w
approved these changes
Aug 18, 2025
| @@ -441,6 +448,9 @@ def __init__( | |||
| downsample_block_type: str = "pixel_unshuffle", | |||
| decoder_norm_types: Union[str, Tuple[str]] = "rms_norm", | |||
| decoder_act_fns: Union[str, Tuple[str]] = "silu", | |||
| encoder_out_shortcut: bool = True, | |||
There was a problem hiding this comment.
Just noting for other reviewers - this change looks safe because previous out_shortcut default was True as well in the encoder
| @@ -441,6 +448,9 @@ def __init__( | |||
| downsample_block_type: str = "pixel_unshuffle", | |||
| decoder_norm_types: Union[str, Tuple[str]] = "rms_norm", | |||
| decoder_act_fns: Union[str, Tuple[str]] = "silu", | |||
| encoder_out_shortcut: bool = True, | |||
| decoder_in_shortcut: bool = True, | |||
There was a problem hiding this comment.
This change is safe because previous in_shortcut default was True in decoder
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Failing tests are unrelated |
|
@a-r-r-o-w Thanks so much for your support! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR will add minor modification to support DC-AE-turbo into the diffusers lib.
dc-ae-turbo-f32c32-sana-1.1has the same encoder asdc-ae-f32c32-sana-1.0and a lightweight decoder to accelerate decoding.Could you please have a look? Thanks! @sayakpaul @yiyixuxu
Cc: @lawrence-cj