Skip to content

DummyServer::Servlet#not_found requires two arguments #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2023
Merged

DummyServer::Servlet#not_found requires two arguments #761

merged 1 commit into from
Sep 10, 2023

Conversation

c960657
Copy link
Contributor

@c960657 c960657 commented Sep 6, 2023

If you request an unsupported URL from DummyServer, you get a 500 Internal Server Error instead of a 404 Not Found.

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN">
<HTML>
  <HEAD><TITLE>Internal Server Error</TITLE></HEAD>
  <BODY>
    <H1>Internal Server Error</H1>
    wrong number of arguments (given 0, expected 2)
    <HR>
    <ADDRESS>
     WEBrick/1.8.1 (Ruby/3.2.2/2023-03-30) at
     127.0.0.1:63416
    </ADDRESS>
  </BODY>
</HTML>

@c960657 c960657 changed the title DummyServer#not_found requires two arguments DummyServer::Servlet#not_found requires two arguments Sep 6, 2023
@tarcieri tarcieri merged commit 4060ccd into httprb:main Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c960657 @tarcieri