Update a bunch of upstream dependencies to align with Scala 2.12.20 and 2.13.15 #7541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Executed command: sbt tlPrePrBotHook
danicheg
reviewed
Oct 13, 2024
| @@ -33,7 +33,7 @@ class UseLiteralsSyntax extends SemanticRule("Http4sUseLiteralsSyntax") { | |||
| List(lit @ Lit.String(_)) | |||
| ) => | |||
| Patch.replaceTree(t, s"path$lit") + importLiteralsIfNeeded | |||
| case t if t.syntax == """Uri.Path.unsafeFromString("foo/bar")""" => show(t) | |||
| case t if t.text == """Uri.Path.unsafeFromString("foo/bar")""" => show(t) | |||
There was a problem hiding this comment.
That change comes from https://github.com/scalameta/scalameta/releases/tag/v4.10.0
It echoes with scalameta/scalameta#3864
There was a problem hiding this comment.
By the way, that line seems to be for debugging purposes. I'm not sure we should keep it.
This was referenced Oct 13, 2024
|
Phew, as we go deeper into the forest, things are getting complicated. For this time, CI is green. ΡΡ @http4s/core |
rossabaker
approved these changes
Oct 14, 2024
|
I think the scalafix issue here is breaking multiple repos on the sbt-http4s-org upgrade. |
|
Maybe we need to supply an unscheduled patch release to fix that issue with scalafix. |
|
Is the lack of release here what is causing the MatchErrors in various repos, like this? I have no mental model of how scalafix versioning works across repos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this PR
π¦ Updates org.http4s:sbt-http4s-org from
0.17.3to0.17.4π GitHub Release Notes - Version Diff
Usage
β Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
π Files still referring to the old version number
The following files still refer to the old version number (0.17.3).
You might want to review and update them manually.
β Adjust future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: