Fix for Uri macro with org variable
#7537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
org variable
|
Also realized that uri macro wasn't working if an implicit variable scala> import org.http4s.implicits._
import org.http4s.implicits._
scala> implicit val org: String = "the-problem"
val org: String = the-problem
scala> uri"test"
^
error: value http4s is not a member of StringAdded a test for this behaviour as well and confirmed that it fails without 532c401 and passes with it. |
6976a16 to
7ab3193
Compare
danicheg
approved these changes
Oct 10, 2024
tests/shared/src/test/scala/org/http4s/LiteralSyntaxMacrosSuite.scala
Outdated
Show resolved
Hide resolved
1dd18ad to
9e5375e
Compare
hamnis
reviewed
Oct 15, 2024
hamnis
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without the
_root_in the uri macro, the added test fails to compile witherror: value http4s is not a member of StringThis issue was originally fixed in #741, but in the intervening years + refactors the
_root_qualifier was dropped. I'm just re-adding it, and I'm adding it to all the literal macros just to be safe.fixes #704