_root_-qualify absolute paths in macro expansions. #741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes bug #704.
Current coverage is 62.38% (diff: 100%)@@ master #741 diff @@
==========================================
Files 208 208
Lines 4416 4416
Methods 3968 3968
Messages 0 0
Branches 442 442
==========================================
+ Hits 2747 2755 +8
+ Misses 1669 1661 -8
Partials 0 0
|
rossabaker
approved these changes
Oct 23, 2016
|
Sorry, this escaped me. Looks good! 👍 |
|
Cherry-picked and publishing as 0.14.11. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes bug #704.
The issue isn't so much using that symbol after
/, but that scala was picking it up as part of the expansion of the macro quasiquote atUri.scala:124.Also fixes this bug in
QValue.scala, just in case.