Skip to content

Conversation

FrancescoSerra
Copy link
Contributor

This is the only missing Ordering I could find - all the other data types extend Ordered, which then allows deriving Ordering with implicit extension from cats

Closes #5017

@mergify mergify bot added series/0.23 PRs targeting 0.23.x module:core labels Jun 22, 2022
* Copyright 2013-2020 http4s.org
* Copyright 2013-2022 http4s.org
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spurious change? :) see also #5525

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh, thanks! It's good to know. Will rectify :-)

Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking these!

@armanbilge armanbilge merged commit 6b59174 into http4s:series/0.23 Jun 23, 2022
@FrancescoSerra FrancescoSerra deleted the add-ordering-for-data-types branch June 23, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:core series/0.23 PRs targeting 0.23.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Be Consistent About Providing An Ordering Instance
2 participants