Add filename property to Content-Disposition #6485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danicheg
approved these changes
Jun 22, 2022
There was a problem hiding this comment.
The notable differences between the two approaches:
- Users that parse
filenamefrom theparametersmanually will get new behavior without changes in their code (if we will do things in parser*). - Doing 'magic' within the parser will allow us to soft parsing rules for
filenamein case of the presence offilename*. To fix this issue #5809, for example. I was planning to dig into it further. But probably we are doing well in strict behavior. It's needed to clarify.
Nevertheless, I like this PR. It seems more transparent and less tricky, to be honest. So it's up to you to decide where we go with this.
|
Yeah, I like preserving both parameters as they came to us, but giving a method that gives an interpretation that steers toward proper interpretation of the spec. What to do about parsing non-Latin-1 in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per RFC6266, Section 4.3, if
filename*is defined, prefer that. If not, tryfilename.Kind of like #6475, but lossless.